Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snooper 1.2.1.1 #2819

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Snooper 1.2.1.1 #2819

merged 2 commits into from
Nov 2, 2023

Conversation

Maia-Everett
Copy link
Contributor

@Maia-Everett Maia-Everett commented Nov 1, 2023 •
edited
Loading

  • Snooper will no longer play a sound when you send a tell. This was never intended. (#18)
  • If saving logs to disk is disabled, Snooper will no longer load already existing logs from disk.
  • Reduced plugin log spam, fixing an issue where exception stack traces were logged for normal operation.

@bleatbot bleatbot enabled auto-merge (squash) November 1, 2023 13:59
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 1, 2023 •
edited
Loading

Outdated attempt

⚠️ No builds attempted! This probably means that your owners property is misconfigured.
The average merge time for plugin updates is currently 19 hours.

Name Commit Status
Show log - Review

auto-merge was automatically disabled November 1, 2023 14:02

Head branch was pushed to by a user without write access

@bleatbot
Copy link
Collaborator

bleatbot commented Nov 1, 2023 •
edited
Loading

Outdated attempt

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️Snooper [stable] - bdd2ecc - v1.2.1.0 - Diff (465 lines, prev. 1.2.0.0)

Show log - Review

@bleatbot bleatbot added the size-mid Diff for this PR is mid-sized. label Nov 1, 2023
@Maia-Everett
Copy link
Contributor Author

Maia-Everett commented Nov 1, 2023 •
edited
Loading

The diff looks bigger than it is because of a whitespace formatting commit. Here's the real diff:

https://github.com/Maia-Everett/dalamud-snooper/compare/f0ae06a7e3cacb47ee528df0c3e76cf7ce52b3f8..v1.2.1.1

@Maia-Everett Maia-Everett changed the title Snooper 1.2.1.0 Snooper 1.2.1.1 Nov 2, 2023
@bleatbot
Copy link
Collaborator

bleatbot commented Nov 2, 2023

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

✔️Snooper [stable] - a0fa7be - v1.2.1.1 - Diff (470 lines, prev. 1.2.0.0)

Show log - Review

@reiichi001 reiichi001 merged commit 2feb7cb into goatcorp:main Nov 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reiichi001 reiichi001 reiichi001 approved these changes

Assignees
No one assigned
Labels
size-mid Diff for this PR is mid-sized.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Maia-Everett @bleatbot @reiichi001